Re: [Openvpn-users] Assertion failed at mroute.c:349

[Erich Titl <erich.titl@xxxxxxxx>]

Paul

I looked at the assertion error, it appears to be triggered by a call to
 multi_del_iroutes and hence mroute_helper_del_iroute. just before the
assertion net_len_refcount is decremented and thus may become negative.

I believe the following code is not entirely correct and does not
rgenerate the refcount if it becomes zero.

mroute.c:

      if (!mh->net_len_refcount[ir->netbits])
        mroute_helper_regenerate (mh);

IMHO should read

      if (mh->net_len_refcount[ir->netbits] < 1)
        mroute_helper_regenerate (mh);

because this regeneration takes place when the first iroute ets added
too. It may be possible that the regeneration code is not executed in a
previous call to mroute_helper_del_iroute call and thus the refcount
gets decremented below zero in a subsequent call.

James, would you mind to comment on this?

Thanks

Erich


____________________________________________
Openvpn-users mailing list
Openvpn-users@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/openvpn-users